Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workflow permission to write github pages #204

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

McHaillet
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 2, 2024

File Coverage Missing
All files 87%
src/pytom_tm/correlation.py 85% 97-98 129
src/pytom_tm/entry_points.py 79% 28 111-128 231-276 371-389 514-531 978-989
src/pytom_tm/extract.py 75% 122-133 193-200 235-240 332-350
src/pytom_tm/io.py 80% 19 40 58 76 88 108-115 131-135 143 150 161 168 214-216 280 316-319 420-428 453
src/pytom_tm/mask.py 80% 72 90 100-101
src/pytom_tm/parallel.py 89% 14-15 89 100-101 107 170
src/pytom_tm/plotting.py 16% 19-21 24-31 35-43 47-50 53-69 72-73 76-77 97-102 118-126 132-149 164-172 176-193 197-205 209-216 222 228 233 247-395
src/pytom_tm/tmjob.py 97% 301-302 318 327-331 398 519 563
src/pytom_tm/utils.py 78% 17-19
src/pytom_tm/weights.py 96% 57 304-307 314 519 524 529

Minimum allowed coverage is 86%

Generated by 🐒 cobertura-action against 38e3962

@McHaillet
Copy link
Collaborator Author

This has some info about deploying mkdocs: https://github.com/marketplace/actions/deploy-mkdocs

It says the following:

You may need to give the GITHUB_TOKEN write permission. Go to your repository's Settings > Actions > General > Workflow Permissions and select Read and write permissions.

I am not sure whether permission contents: write does the same. As github docs says contents only controls this:

Work with the contents of the repository. For example, contents: read permits an action to list the commits, and contents: write allows the action to create a release. For more information, see "Permissions required for GitHub Apps."

@McHaillet
Copy link
Collaborator Author

@McHaillet
Copy link
Collaborator Author

McHaillet commented Aug 2, 2024

@sroet I think you were right and it should be "contents: write"

The mkdocs-material page also uses that: https://squidfunk.github.io/mkdocs-material/publishing-your-site/#with-github-actions-material-for-mkdocs

@McHaillet McHaillet requested a review from sroet August 2, 2024 18:14
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤞 Let's hope this is enough to get it up and running

@McHaillet McHaillet merged commit 5002558 into main Aug 2, 2024
2 checks passed
@McHaillet McHaillet deleted the McHaillet-patch-1 branch August 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants